-
Notifications
You must be signed in to change notification settings - Fork 996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes the instrument kind for noop async instruments #2461
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2461 +/- ##
=====================================
Coverage 76.3% 76.3%
=====================================
Files 173 173
Lines 12010 12022 +12
=====================================
+ Hits 9167 9179 +12
Misses 2598 2598
Partials 245 245
|
I have a fundamental disagreement on the underlying problem that the test exposes. Put simply, we assume that if descriptor.Name(), descriptor.InstrumentKind() and descriptor.NumberKind() all match, then the Instrument stored in the map MUST be the same type. The solution to this should then be either:
This way if this registry is ever used again we don't find ourselves retreading this. |
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@MadVikingGod no test anymore, this is still a bug fix so please prioritize. |
Fixes #2460
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com